Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Memory Leaks in V8StringToChar and its invocations #391

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

ashishnegi commented Sep 12, 2013

Following on the issue https://github.com/appjs/appjs/issues/382 I have used:

  1. std::unique_ptr instead of raw pointers.
  2. Invocations of V8StringToChar has been changed to either get() or release(), depending upon what i thought was required at that position.

I first tried with shared_ptr but since we do not need many pointers to point to this memory we should use unique_ptr. Hence moved to it.

Owner

milani commented Sep 13, 2013

Thank you:) Let me merge it manually and test on other platforms.

Contributor

ashishnegi commented Sep 13, 2013

That would be right way. If this would test right, i would also do it for the rest of other functions like V8StringToWchar .

Owner

IngwiePhoenix commented Dec 22, 2013

Is this still current? If so, I'd merge it if possible - or needed. I belive @milani hasn't merged it yet.

Contributor

ashishnegi commented Dec 23, 2013

Yaa. he had talked about looking into it on local machine.

Owner

IngwiePhoenix commented Dec 23, 2013

Altight, looks like thats my job now, as I own appjs now. Or more, i am the head maintainer. :) Let’s see how that’ll behave! ^^
Am 23.12.2013 um 13:00 schrieb ASHISH NEGI notifications@github.com:

Yaa. he had talked about looking into it on local machine.


Reply to this email directly or view it on GitHub.

Contributor

ashishnegi commented Feb 10, 2014

any progress on this Ingwie.

Contributor

ashishnegi commented May 26, 2016

Closing PR as no response for long time.

@ashishnegi ashishnegi closed this May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment