From fee92d7d1d9b47ef0cab4159e23464d1e4db17a8 Mon Sep 17 00:00:00 2001 From: appkr Date: Fri, 22 Jan 2016 23:58:27 +0900 Subject: [PATCH] remove env helper for config helper in code to avoid error when env key is not defined. readme touched for SEO. rebase and squash unnecessary commit logs --- app/Http/routes.php | 4 ++-- app/Transformers/AttachmentTransformer.php | 2 +- app/helpers.php | 2 +- config/project.php | 2 ++ lessons/33-social-login.md | 4 ++-- readme.md | 4 +++- resources/views/layouts/master.blade.php | 2 +- tests/integration/Http/Controllers/Api/ApiTest.php | 2 +- tests/integration/Http/Controllers/AuthTest.php | 2 +- 9 files changed, 14 insertions(+), 10 deletions(-) diff --git a/app/Http/routes.php b/app/Http/routes.php index b201f88..540af90 100644 --- a/app/Http/routes.php +++ b/app/Http/routes.php @@ -1,6 +1,6 @@ env('API_DOMAIN'), 'as' => 'api.', 'namespace' => 'Api', 'middleware' => 'cors'], function() { +Route::group(['domain' => config('project.api_domain'), 'as' => 'api.', 'namespace' => 'Api', 'middleware' => 'cors'], function() { /* Landing page */ Route::get('/', [ 'as' => 'index', @@ -64,7 +64,7 @@ }); }); -Route::group(['domain' => env('APP_DOMAIN')], function() { +Route::group(['domain' => config('project.app_domain')], function() { /* Landing page */ Route::get('/', [ 'as' => 'index', diff --git a/app/Transformers/AttachmentTransformer.php b/app/Transformers/AttachmentTransformer.php index c44cf05..b4a9382 100644 --- a/app/Transformers/AttachmentTransformer.php +++ b/app/Transformers/AttachmentTransformer.php @@ -22,7 +22,7 @@ public function transform(Attachment $attachment) 'created' => $attachment->created_at->toIso8601String(), 'link' => [ 'rel' => 'self', - 'href' => url(sprintf('http://%s:8000/attachments/%s', env('APP_DOMAIN'), $attachment->name)), + 'href' => url(sprintf('http://%s:8000/attachments/%s', config('project.app_domain'), $attachment->name)), ], ]; diff --git a/app/helpers.php b/app/helpers.php index fe4cd4b..05930d2 100644 --- a/app/helpers.php +++ b/app/helpers.php @@ -150,7 +150,7 @@ function current_url() */ function is_api_request() { - return starts_with(request()->getHttpHost(), env('API_DOMAIN')); + return starts_with(request()->getHttpHost(), config('project.api_domain')); } } diff --git a/config/project.php b/config/project.php index f3c10c5..3930db9 100644 --- a/config/project.php +++ b/config/project.php @@ -21,6 +21,8 @@ */ 'name' => 'l5essential', 'description' => 'Laravel 5 입문 및 실전 강좌', + 'app_domain' => env('APP_DOMAIN', 'myproject.dev'), + 'api_domain' => env('API_DOMAIN', 'api.myproject.dev'), /* |-------------------------------------------------------------------------- diff --git a/lessons/33-social-login.md b/lessons/33-social-login.md index 93aca9b..4fe9039 100644 --- a/lessons/33-social-login.md +++ b/lessons/33-social-login.md @@ -170,8 +170,8 @@ class AuthController extends Controller --- - [목록으로 돌아가기](../readme.md) -- [32강 - 사용자 로그인](docs/32-login.md) -- [34강 - 사용자 역할](docs/34-role.md) +- [32강 - 사용자 로그인](32-login.md) +- [34강 - 사용자 역할](34-role.md) diff --git a/readme.md b/readme.md index 516576e..5998cb1 100644 --- a/readme.md +++ b/readme.md @@ -1,7 +1,9 @@ -# 라라벨 5 입문 및 실전 강좌 +# 라라벨 (Laravel) 5 입문 및 실전 강좌 [![Build Status](https://travis-ci.org/appkr/l5essential.svg)](https://travis-ci.org/appkr/l5essential) +라라벨은 PHP 언어로 개발된 풀스택 웹 어플리케이션 프레임웍이다. + ## 라이브 데모 사이트 아래 주소를 방문하면 이 강좌에서 개발한 최종 결과물을 볼 수 있다. diff --git a/resources/views/layouts/master.blade.php b/resources/views/layouts/master.blade.php index 74be28a..6f14cc0 100644 --- a/resources/views/layouts/master.blade.php +++ b/resources/views/layouts/master.blade.php @@ -11,7 +11,7 @@ - + diff --git a/tests/integration/Http/Controllers/Api/ApiTest.php b/tests/integration/Http/Controllers/Api/ApiTest.php index d6aeea4..a0be4f7 100644 --- a/tests/integration/Http/Controllers/Api/ApiTest.php +++ b/tests/integration/Http/Controllers/Api/ApiTest.php @@ -50,7 +50,7 @@ class ApiTest extends \TestCase public function setUp() { parent::setUp(); - $this->baseUrl = sprintf('http://' . env('API_DOMAIN')); + $this->baseUrl = 'http://' . config('project.api_domain'); } /** diff --git a/tests/integration/Http/Controllers/AuthTest.php b/tests/integration/Http/Controllers/AuthTest.php index 41ab2ab..173b90c 100644 --- a/tests/integration/Http/Controllers/AuthTest.php +++ b/tests/integration/Http/Controllers/AuthTest.php @@ -45,7 +45,7 @@ class AuthTest extends \TestCase public function setUp() { parent::setUp(); - $this->baseUrl = sprintf('http://' . env('APP_DOMAIN')); + $this->baseUrl = 'http://' . config('project.app_domain'); } /**