From e8a2ac33b35052d4c31a477f6085b7915af2848b Mon Sep 17 00:00:00 2001 From: Alex Baker Date: Thu, 20 Feb 2025 09:50:52 -0800 Subject: [PATCH] Throw ValueError if environment not one of the supported values Python does not enforce typing, meaning invalid types are possible --- appstoreserverlibrary/api_client.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/appstoreserverlibrary/api_client.py b/appstoreserverlibrary/api_client.py index 5c383de7..890cdfef 100644 --- a/appstoreserverlibrary/api_client.py +++ b/appstoreserverlibrary/api_client.py @@ -466,8 +466,10 @@ def __init__(self, signing_key: bytes, key_id: str, issuer_id: str, bundle_id: s self._base_url = "https://api.storekit.itunes.apple.com" elif environment == Environment.LOCAL_TESTING: self._base_url = "https://local-testing-base-url" - else: + elif environment == Environment.SANDBOX: self._base_url = "https://api.storekit-sandbox.itunes.apple.com" + else: + raise ValueError("Invalid environment provided") self._signing_key = serialization.load_pem_private_key(signing_key, password=None, backend=default_backend()) self._key_id = key_id self._issuer_id = issuer_id