Skip to content
This repository has been archived by the owner. It is now read-only.

Hardcoded "WebDAV:" xattr prefix breaks Linux compatibility #173

Closed
macosforgebot opened this issue May 16, 2009 · 9 comments
Closed

Hardcoded "WebDAV:" xattr prefix breaks Linux compatibility #173

macosforgebot opened this issue May 16, 2009 · 9 comments

Comments

@macosforgebot
Copy link

@macosforgebot macosforgebot commented May 16, 2009

christoph_apple@… originally submitted this as ticket:337

  • Cc: alexis@…

Linux requires a "user." prefix when setting extended attributes but CalendarServer uses a hardcoded "WebDAV:" prefix on various occasions. At least the following files seem to be affected:

calendarserver/tools/fixcalendardata.py
calendarserver/tools/doublequotefix.py
contrib/tools/fix_calendar
twistedcaldav/test/test_upgrade.py
twistedcaldav/test/data/makelargefbset.py
twistedcaldav/upgrade.py
twistedcaldav/admin/util.py

The attached patch fixes this problem for fix_calendar but has not been tested on non-Linux platforms.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented May 16, 2009

christoph_apple@… originally submitted this as attachment:fix_calendar-linux-xattr-fix.patch:⁠ticket:337


fix_calendar Linux xattr Fix

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Apr 12, 2010

sammys@… originally submitted this as attachment:upgrade-linux-xattr-fix.patch:⁠ticket:337


Fixes xattr incompatibility in linux (twistedcaldav/upgrade.py)

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Apr 12, 2010

sammys@… originally submitted this as comment:1:⁠ticket:337


I have attached a patch to fix the incompatibility when upgrading calendars from the old format to the new format (e.g calendarserver 1.2 to calendarserver 2.4).

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Apr 14, 2010

apm@… originally submitted this as comment:2:⁠ticket:337


bin/xattr is affected as well.

Maybe the correct solution is to override the whole xattr class for Linux and import linuxxattr as xattr. I've attached a linuxxattr/init.py

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Apr 14, 2010

apm@… originally submitted this as attachment:init.py:⁠ticket:337

  • Attachment init.py (1.1 KB) added

a linuxxattr/init.py class

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Aug 9, 2010

alexis@… originally submitted this as comment:3:⁠ticket:337

  • Cc alexis@… added
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Aug 9, 2010

alexis@… originally submitted this as comment:4:⁠ticket:337

  • Cc alexis@… removed
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Aug 9, 2010

alexis@… originally submitted this as comment:5:⁠ticket:337

  • Cc alexis@… added
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Jan 24, 2013

@wsanchez originally submitted this as comment:9:⁠ticket:337

  • Status changed from new to closed
  • Resolution set to Not to be fixed

The xattr property store is obsolete, and to the degree that this code is used at all, it's to only migrate from previously working data stores using it, so there no plan to fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.