Skip to content
This repository has been archived by the owner. It is now read-only.

./run script have Perl run-time dependency. #227

Closed
macosforgebot opened this issue Jun 20, 2008 · 3 comments
Closed

./run script have Perl run-time dependency. #227

macosforgebot opened this issue Jun 20, 2008 · 3 comments

Comments

@macosforgebot
Copy link

@macosforgebot macosforgebot commented Jun 20, 2008

bland@… originally submitted this as ticket:286

  • Version: trunk

./run script uses xpath utility to fetch values out of caldavd.plist. This utility is Perl based and adds excessive dependency to CalendarServer bundle. It will be nice to switchover to PyXML inline code instead.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Jul 17, 2008

@wsanchez originally submitted this as comment:1:⁠ticket:286

  • Status changed from new to assigned
  • Milestone set to Later

That's a fair point, though that functionality is only for obtaining a specific config key... Also, the ./run script is only meant for developers, not users, so it's not a high priority.

If someone can whip up a PyXML-based xpath tool, I'd be happy to call into that instead. Even better, use elementtree if that's possible, since we'd like to get rid of PyXML as well).

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Sep 13, 2009

matthias@… originally submitted this as comment:2:⁠ticket:286


Hi. I've installed CalendarServer on Ubuntu and it took me an hour to figure out that xpath is used by run.sh to get config keys. It would be nice, if this would at least be mentioned as requirement, see #⁠79. An error message that xpath is not installed would also be nice.

Besides this, I had to change config_key to this:

conf_read_key () {

local key="$1"; shift;

FIXME: This only works for simple values (no arrays, dicts) tr '\n' ' ' < "${config}" \

| xpath -e "/plist/dict/[preceding-sibling::key[1]='${key}'" 2> /dev/null \ | head -n 1 \ | sed -n 's|<[<][<]>([<])</[<][<]>.*$|\1|p';

}

as xapth requires the "-e" flag and it returns two nodes.

Thanks,

Matthias Ringwald

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Feb 6, 2013

@wsanchez originally submitted this as comment:10:⁠ticket:286

  • Status changed from assigned to closed
  • Milestone changed from Later to CalendarServer-4.x
  • Resolution set to Software changed

This was fixed in r6400, 2010-10-05.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.