Skip to content
This repository has been archived by the owner. It is now read-only.

Apache directory service types broken? #241

Closed
macosforgebot opened this issue Sep 21, 2008 · 7 comments
Closed

Apache directory service types broken? #241

macosforgebot opened this issue Sep 21, 2008 · 7 comments

Comments

@macosforgebot
Copy link

@macosforgebot macosforgebot commented Sep 21, 2008

msantos@… originally submitted this as ticket:305

  • Version: trunk

It appears that the Apache directory service types are broken. Code in udpateDirectoryService() in config.py seems to be trying to validate the directory service parameters from the config file against the known keywords, but there is no entry for them in serviceDefaultParams[], so the code takes a KeyError exception at this line:

if param not in serviceDefaultParams[dsType]:

because dsType is twistedcaldav.directory.apache.DigestDirectoryService, but the list in config.py only has entries for:

twistedcaldav.directory.xmlfile.XMLDirectoryService twistedcaldav.directory.appleopendirectory.OpenDirectoryService

Maybe that list is supposed to be updated somewhere else (from apache.py?), but I couldn't find any such place.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Oct 27, 2008

@wsanchez originally submitted this as comment:1:⁠ticket:305

  • Status changed from new to assigned

See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503727 for a Debian bug on this and a patch.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Oct 29, 2008

@agx originally submitted this as comment:2:⁠ticket:305

  • Description modified

Hi Winfredo, the patch makes sense to me. Can it be applied?

-- Guido

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Oct 29, 2008

@agx originally submitted this as comment:3:⁠ticket:305

  • Description modified

Replying to msantos@…:

Hi Winfredo, the patch in the BTS

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Oct 29, 2008

@agx originally submitted this as comment:4:⁠ticket:305


Whoops. I didn't mean to change the description, just wanted to add a comment.

Hi Winfredo, the patch makes sense to me. Can it be applied?

Sorry for the noise.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Oct 29, 2008

@wsanchez originally submitted this as comment:5:⁠ticket:305


OK, I applied these and some other work that seemed obviously lacking. The files appear to read in correctly, but a couple of things (at least) are still broken:

  • the basic verifyCredentials bits still don't work for me; I wasn't able to auth
  • the digest verifyCredentials bits are unimplemented
  • the digest directory service doesn't filter out records with a non-matching realm (realm seems irrelevant to basic)
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Apr 29, 2009

@wsanchez originally submitted this as comment:6:⁠ticket:305

  • Priority changed from 5: Not set to 3: Important
  • Milestone set to Later
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Feb 25, 2010

@wsanchez originally submitted this as comment:7:⁠ticket:305

  • Status changed from assigned to closed
  • Resolution changed from to Software changed

This functionality was removed for 3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.