Skip to content
This repository has been archived by the owner. It is now read-only.

doQuery should call returnValue on return #303

Closed
macosforgebot opened this issue Jun 25, 2010 · 3 comments
Closed

doQuery should call returnValue on return #303

macosforgebot opened this issue Jun 25, 2010 · 3 comments

Comments

@macosforgebot
Copy link

@macosforgebot macosforgebot commented Jun 25, 2010

erb@… originally submitted this as ticket:382

  • Cc: erb@…, apm@…

In twistedcaldav/method/report_calquery.py the subfunction doQuery is declared with @inlineCallbacks, so it ought to call returnValue instead of return at line 184.

Also it should return True otherwise report_common.applyToCalendarCollections won't apply doQuery to all calendar collections.

A patch is included. This also applies to trunk, although the filename has been changed.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Jun 25, 2010

erb@… originally submitted this as attachment:report_calquery.patch:⁠ticket:382

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Jun 30, 2010

apm@… originally submitted this as comment:1:⁠ticket:382

  • Cc apm@… added
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Aug 1, 2011

@wsanchez originally submitted this as comment:2:⁠ticket:382

  • Radar deleted
  • Status changed from new to closed
  • Milestone changed from CalendarServer-2.4 to CalendarServer-3.0
  • Resolution changed from to Software changed

Fixed in 3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.