Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
getetag return None in calendar folders when using sql datastore backend #316
pedro@… originally submitted this as ticket:405
getetags must return a consistent value that helps keeping track of folder changes.
I have traced the bug to the file md5() function in CommonHomeChild class within txdav/common/datastore/sql.py. This function return None always.
mail@… originally submitted this as comment:1:ticket:405
Just to clarify:
In source:/CalendarServer/trunk/txdav/common/datastore/sql.py@6909#L1663 there is in fact simply none returned.
ETags are not an appropriate way to track changes to collection resources; it's only a good way to track the rendered representation of a collection. There is no requirement that ETags change when collections add or remove members, etc.
This is why we invented CTags as a work-around and now support the sync report.