Skip to content
This repository has been archived by the owner. It is now read-only.

getetag return None in calendar folders when using sql datastore backend #316

Closed
macosforgebot opened this issue Jan 7, 2011 · 2 comments
Closed

Comments

@macosforgebot
Copy link

@macosforgebot macosforgebot commented Jan 7, 2011

pedro@… originally submitted this as ticket:405


getetags must return a consistent value that helps keeping track of folder changes.

I have traced the bug to the file md5() function in CommonHomeChild class within txdav/common/datastore/sql.py. This function return None always.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Feb 8, 2011

mail@… originally submitted this as comment:1:⁠ticket:405


Just to clarify:

In source:/CalendarServer/trunk/txdav/common/datastore/sql.py@6909#L1663 there is in fact simply none returned.

    def md5(self):
        return None
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Aug 1, 2011

@wsanchez originally submitted this as comment:2:⁠ticket:405

  • Status changed from new to closed
  • Resolution changed from to Behaves correctly

ETags are not an appropriate way to track changes to collection resources; it's only a good way to track the rendered representation of a collection. There is no requirement that ETags change when collections add or remove members, etc.

This is why we invented CTags as a work-around and now support the sync report.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.