Skip to content
This repository has been archived by the owner. It is now read-only.

[PATCH] fix some gettext issues #319

Closed
macosforgebot opened this issue Feb 7, 2011 · 4 comments
Closed

[PATCH] fix some gettext issues #319

macosforgebot opened this issue Feb 7, 2011 · 4 comments

Comments

@macosforgebot
Copy link

@macosforgebot macosforgebot commented Feb 7, 2011

mail@… originally submitted this as ticket:411


Running gettext one got the following output:

fm@thinkpad:~/CalendarServer # pygettext.py twistedcaldav/localization.py twistedcaldav/mail.py 
*** twistedcaldav/localization.py:225: Seen unexpected token "daysFull"
*** twistedcaldav/localization.py:226: Seen unexpected token "monthsFull"
*** twistedcaldav/localization.py:250: Seen unexpected token "ampm"
*** twistedcaldav/localization.py:269: Seen unexpected token "%"

The first three are doubled as far as i can see and the last one is a real bug.

Attached patch fixes it.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Feb 19, 2011

mail@… originally submitted this as attachment:calendarserver-localization.py.patch:⁠ticket:411


correct issue with patch

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Feb 19, 2011

mail@… originally submitted this as comment:1:⁠ticket:411


The first part of my patch was wrong as _ is not bound to gettext the first time and therefore the values are not translated twice...

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Aug 1, 2011

@wsanchez originally submitted this as comment:2:⁠ticket:411

  • Owner changed from @wsanchez to @m0rgen
  • Priority changed from 5: Not set to 2: Expected
  • Milestone set to CalendarServer-3.2
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Sep 28, 2012

@m0rgen originally submitted this as comment:3:⁠ticket:411

  • Status changed from new to closed
  • Resolution set to Software changed

Thanks for the patch -- I just applied it and added more tests. I'm not exactly sure why the daysFull token is causing a problem, but I am using xgettext now instead of pygettext.py

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.