Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
replies to tokenized mails are not forwared correctly #324
mail@… originally submitted this as ticket:416
when replying to a tokenized mail, the message should be forwared. This does not work with r6910.
The header is included twice in the mail send to the organizer:
With the following patch, to strip out the envelope header:
One gets the following:
I am not able to reproduce this using OS X Server. I tested by having Calendar Server send an iMIP invite to a gmail account, and then instead of using the iMIP mechanism within gmail to respond, I hit the Reply button and typed in some text without including the .ics attachment. This caused Calendar Server to forward that message to the original organizer of the event (with no header duplication).
mail@… originally submitted this as attachment:calendarserver-mailforwarding.patch:ticket:416
patch to fix all mail forwarding issues for me
mail@… originally submitted this as comment:3:ticket:416
I spend a long time debugging this issue.
This issue is caused by different linebreaks: It was caused by somehow incorrect lineending handling.
Read from my IMAP, I have message containing \r\n when they get read by message_from_string() They are delimited by \n in the header and still \r\n in the content.
Sending the mail via ESMTPSenderFactory() now creates two \n into \r\n as of RFC2822, but does so for the content too, therefore too many line breaks are in there.
One MUST NOT use str(msg) as this contains the unix header (envelope) and therefore the headers will be added twice ...
My issue416.py is useless and wrong. But calendarserver-mailforwarding.patch solves all my problems.
Sorry for the delay, how's this: https://trac.calendarserver.org/changeset/7819/CalendarServer/trunk