Skip to content
This repository has been archived by the owner. It is now read-only.

listProperties used excessively #416

Closed
macosforgebot opened this issue Dec 5, 2006 · 9 comments
Closed

listProperties used excessively #416

macosforgebot opened this issue Dec 5, 2006 · 9 comments

Comments

@macosforgebot
Copy link

@macosforgebot macosforgebot commented Dec 5, 2006

@cyrusdaboo originally submitted this as ticket:88

  • Owner: @glyph
  • Version: 1.0-dev

There are many instances where twisted.web2.dav.resource.listProperties is used inside a loop in which it is likely to be invariant (e.g. twisted.web2.dav.method.prop_common._namedPropertiesForResource). The call to listProperties should be moved outside of the enclosing loops. Do a project wide search for listProperties and correct each case.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Dec 5, 2006

@wsanchez originally submitted this as comment:1:⁠ticket:88

  • Priority changed from 3: Important to 2: Expected
  • Milestone changed from CalDAV-access to Preview 1
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Jan 29, 2007

@wsanchez originally submitted this as comment:2:⁠ticket:88

  • Milestone changed from Preview 1 to Version One
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Jul 30, 2007

@wsanchez originally submitted this as comment:3:⁠ticket:88

  • Milestone changed from 1.0 to 1.1
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Dec 15, 2007

@wsanchez originally submitted this as comment:4:⁠ticket:88

  • Milestone changed from 1.1 to 2.0
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Oct 26, 2009

@wsanchez originally submitted this as comment:5:⁠ticket:88

  • Milestone changed from CalendarServer-2.x to Later
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Aug 1, 2011

@wsanchez originally submitted this as comment:6:⁠ticket:88

  • Owner changed from @cyrusdaboo to @glyph
  • Radar deleted
  • Milestone changed from Later to CalendarServer-3.x

Might be a good time to look into fixing this

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Sep 26, 2012

@wsanchez originally submitted this as comment:7:⁠ticket:88


./twext/web2/dav/idav.py:    def listProperties(request):
./twext/web2/dav/method/prop_common.py:        props = waitForDeferred(resource.listProperties(request))
./twext/web2/dav/method/propfind.py:                resource_properties = waitForDeferred(resource.listProperties(request))
./twext/web2/dav/resource.py:    def listProperties(self, request):
./twext/web2/dav/resource.py:        See L{IDAVResource.listProperties}.
./twext/web2/dav/resource.py:        L{listProperties} by filtering out elements whose class have
./twext/web2/dav/resource.py:        d = self.listProperties(request)
./twistedcaldav/directory/opendirectorybacker.py:    def listProperties(self, request):
./twistedcaldav/directory/opendirectorybacker.py:        #print("VCardResource.listProperties()")
./twistedcaldav/directory/opendirectorybacker.py:            #print("VCardResource.listProperties: removing dqname=%s" % (dqname,))
./twistedcaldav/directory/opendirectorybacker.py:                #print("listProperties: adding qname=%s" % (qname,))
./twistedcaldav/directory/opendirectorybacker.py:        #for qn in qnames: print("VCardResource.listProperties: qn=%s" % (qn,))
./twistedcaldav/directory/opendirectorybacker.py:    listProperties = deferredGenerator(listProperties)
./twistedcaldav/extensions.py:        whenPropertiesListed = self.resource.listProperties(request)
./twistedcaldav/extensions.py:                    log.err("Property %s was returned by listProperties() "
./twistedcaldav/method/propfind.py:                    resource_properties = (yield resource.listProperties(request))
./twistedcaldav/method/report_common.py:    d = resource.listProperties(request)
./twistedcaldav/method/report_sync_collection.py:                props = (yield resource.listProperties(request))
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Sep 26, 2012

@wsanchez originally submitted this as comment:8:⁠ticket:88

  • Milestone changed from CalendarServer-3.x to Later
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Mar 26, 2015

@wsanchez originally submitted this as comment:20:⁠ticket:88

  • Status changed from new to closed
  • Resolution set to Not to be fixed

Expiring old bugs with unknown state and impact.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.