Skip to content
This repository has been archived by the owner. It is now read-only.

Bad assertion in sendmsg_sendmsg() #463

Closed
macosforgebot opened this issue May 3, 2011 · 4 comments
Closed

Bad assertion in sendmsg_sendmsg() #463

macosforgebot opened this issue May 3, 2011 · 4 comments

Comments

@macosforgebot
Copy link

@macosforgebot macosforgebot commented May 3, 2011

narge-macosforge@… originally submitted this as ticket:443


I recently upgraded caldavd from 2.4 to trunk on a ppc linux machine. After the upgrade, caldavd dies on the first incoming connection, with an assertion failure at twext/python/sendmsg.c line 213.

This assertion states that CMSG_NXTHDR() returns non-NULL. However, it will only return non-NULL if there is space for another control message. Thus, the assertion always fails after copying the last control message; it should be moved to the beginning of the loop, before CMSG_NXTHDR().

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented May 3, 2011

narge-macosforge@… originally submitted this as attachment:caldavd_sendmsg.patch:⁠ticket:443

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented May 3, 2011

@glyph originally submitted this as comment:1:⁠ticket:443


Thanks for your lucidly explained documentation of the bug. The patch is much appreciated.

@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Aug 1, 2011

@wsanchez originally submitted this as comment:2:⁠ticket:443

  • Priority changed from 5: Not set to 2: Expected
  • Milestone set to CalendarServer-3.2
@macosforgebot
Copy link
Author

@macosforgebot macosforgebot commented Aug 1, 2011

@glyph originally submitted this as comment:3:⁠ticket:443

  • Status changed from new to closed
  • Resolution changed from to Software changed

Fixed in r7850

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.