New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on older Pythons #60

Merged
merged 2 commits into from Aug 20, 2017

Conversation

Projects
None yet
3 participants
@behackett
Contributor

behackett commented Aug 10, 2017

This change fixes building on Python 2.4 (the oldest I have available)
through 2.6 and 3.1. It also fixes a few compiler warnings.

By submitting a request, you represent that you have the right to license
your contribution to Apple and the community, and agree that your
contributions are licensed under the Apache License Version 2.0.

For existing files modified by your request, you represent that you have
retained any existing copyright notices and licensing terms. For each new
file in your request, you represent that you have added to the file a
copyright notice (including the year and the copyright owner's name) and the
Calendar and Contacts Server's licensing terms.

Before submitting the request, please make sure that your request follows
the Calendar and Contacts Server's guidelines for contributing
code
.

Fix building on older Pythons
This change fixes building on Python 2.4 (the oldest I have available)
through 2.6 and 3.1. It also fixes a few compiler warnings.
@behackett

This comment has been minimized.

Show comment
Hide comment
@behackett

behackett Aug 10, 2017

Contributor

My main goal here was to re-enable support for Python 2.6 so projects like PyMongo and requests-kerberos can switch back to ccs-pykerberos from various forks. Supporting Python 2.4 and 2.5 just happens to be the same change.

Contributor

behackett commented Aug 10, 2017

My main goal here was to re-enable support for Python 2.6 so projects like PyMongo and requests-kerberos can switch back to ccs-pykerberos from various forks. Supporting Python 2.4 and 2.5 just happens to be the same change.

@jborean93

This comment has been minimized.

Show comment
Hide comment
@jborean93

jborean93 Aug 10, 2017

Contributor

Have tested this manually without any errors against the following versions;

  • 2.6.9
  • 2.7.13
  • 3.3.6
  • 3.4.6
  • 3.5.3
  • 3.6.2
Contributor

jborean93 commented Aug 10, 2017

Have tested this manually without any errors against the following versions;

  • 2.6.9
  • 2.7.13
  • 3.3.6
  • 3.4.6
  • 3.5.3
  • 3.6.2
@behackett

This comment has been minimized.

Show comment
Hide comment
@behackett

behackett Aug 20, 2017

Contributor

@dreness - any comment on this?

Contributor

behackett commented Aug 20, 2017

@dreness - any comment on this?

@dreness

This comment has been minimized.

Show comment
Hide comment
@dreness

dreness Aug 20, 2017

Member

I'm going to do the thing where I merge something right before going offline, in this case for two weeks. But, I don't think this is too risky, plus the tests are passing :)

Member

dreness commented Aug 20, 2017

I'm going to do the thing where I merge something right before going offline, in this case for two weeks. But, I don't think this is too risky, plus the tests are passing :)

@dreness dreness merged commit 6466a37 into apple:master Aug 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment