Fix PR coverage comment never posting#1541
Merged
Merged
Conversation
download-artifact@v8 has a known bug (apple#426) where a single artifact matching a pattern is extracted flat to the working directory without creating a subdirectory. This meant the glob `pr-coverage-*/pr-number.txt` never matched, silently skipping the comment step on every run. Fix by using `merge-multiple: true` with an explicit `path`, giving a deterministic download location regardless of artifact count.
katiewasnothere
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the artifact downloading where a single artifact matching a pattern is extracted flat to the working directory without creating a subdirectory. This meant the glob
pr-coverage-*/pr-number.txtnever matched, silently skipping the comment step on every run.Fixed by using
merge-multiple: truewith an explicitpath, giving a deterministic download location regardless of artifact count.Type of Change
Motivation and Context
Fix the GitHub actions to post coverage numbers
Testing