Reject conflicting DNS flags#1559
Merged
katiewasnothere merged 1 commit intoMay 15, 2026
Merged
Conversation
Contributor
|
Hi @LeSingh1 thank you for contributing! We require that commits be signed, please see https://github.com/apple/containerization/blob/main/CONTRIBUTING.md#pull-requests. Could you update the PR with your commit signed? |
LeSingh1
force-pushed
the
reject-conflicting-dns-flags
branch
from
8d48cb8 to
5b43720
Compare
Contributor
Author
|
Thanks! Updated the PR with a signed commit. |
Code Coverage
|
katiewasnothere
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rejects conflicting DNS configuration when
--no-dnsis supplied together with explicit DNS flags.Motivation
--no-dnsdisables DNS configuration, while--dns,--dns-domain,--dns-option, and--dns-searchexplicitly request DNS configuration. Accepting both makes the command ambiguous.Fixes #1536.
Testing
--no-dnsusage with:--dns--dns-domain--dns-option--dns-searchswift format.Sources/Services/ContainerAPIService/Client/Flags.swiftparses withswift -frontend -parse.Note: full
swift build/test execution is blocked in my local environment by an unrelated dependency/toolchain header issue.