Ensure read-only user config removed on every startup.#1567
Merged
Conversation
- Closes apple#1566. - Currently on `system start` we only remove the read-only user config if the user config file exists. This means that changes to the config are processed properly on restart, but a removal is ignored, and the old read-only settings linger.
noah-thor
approved these changes
May 16, 2026
katiewasnothere
approved these changes
May 16, 2026
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
system startwe only remove the read-only user config if the user config file exists. This means that changes to the config are processed properly on restart, but a removal is ignored, and the old read-only settings linger.Type of Change
Motivation and Context
See above.
Testing