Reorganize Swift package targets for network plugin.#1615
Merged
Conversation
- Part of apple#1404. - Updates containerization to 0.33.2. - Reorganizes network plugin targets into: - `ContainerNetworkClient` - network plugin client and default types - `ContainerNetworkServer` - separate protocols for `Network` which manages the underlying virtual network, `NetworkService`, which takes a network and implements the API, and an actor `NetworkHarness` that marshals between the API and the XPC protocol. The service-harness separation will help us ensure XPC protocol compatibility in both directions as we evolve the plugin APIs. - Removes `disableAllocator()` which is no longer used since apple#1545 switched over to using XPC connections between runtime and network plugin instances to track whether a network has attached containers.
ajemory
approved these changes
May 28, 2026
jglogan
force-pushed
the
networkplugin-reorg
branch
from
7b9915d to
223bb7e
Compare
ajemory
approved these changes
May 28, 2026
Code Coverage
|
ajemory
approved these changes
May 28, 2026
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContainerNetworkClient- network plugin client and default typesContainerNetworkServer- separate protocols forNetworkwhich manages the underlying virtual network,NetworkService, which takes a network and implements the API, and an actorNetworkHarnessthat marshals between the API and the XPC protocol. The service-harness separation will help us ensure XPC protocol compatibility in both directions as we evolve the plugin APIs.disableAllocator()which is no longer used since Remove IP allocation from API server. #1545 switched over to using XPC connections between runtime and network plugin instances to track whether a network has attached containers.Type of Change
Motivation and Context
Revised organization is easier to reason about, helps ensure compatibility as the API evolves, and facilitates other network plugin implementations in the future.
Testing