Fix make test SIGSEGV on Swift 6.2#1638
Merged
Merged
Conversation
jglogan
approved these changes
Jun 4, 2026
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
make testcrashed with signal code 11. Root cause: in HelpCommandTests, #expect(...) compares an optional metatype (ParsableCommand.Type?) against nil. #expect decomposes the comparison into a generic helper, forcing the Swift 6.2 runtime to instantiate generic metadata over the metatype — which segfaults in libswiftCore. (Works fine on 6.3; 6.2 is still supported by Container.)Fix: precompute each comparison into a Bool before passing it to #expect, so it never enters the generic-metadata path. Both crash sites needed it (fixing one moves the crash to the other).
Test: full unit suite now runs to completion on Swift 6.2 — no SIGSEGV.
Closes #1637
Testing