[patch] berkeley/lpc.c does not behave like real BSD lpc #1004

Closed
michaelrsweet opened this Issue Nov 15, 2004 · 3 comments

Comments

Projects
None yet
1 participant
Collaborator

michaelrsweet commented Nov 15, 2004

Version: 1.2-current
CUPS.org User: nardin.inf.ufsc

cups' lpc compatibility command does not understand the 'status all' subcommand of real BSD systems' lpc, treating 'all' as a printer name. Therefore, running 'lpc status all' shows nothing.
This makes software that relies on this (standard) behavior to get a list of printers (like the FreeBSD native Java port), to report no printers available when using cups' lpr compatibility commands.

The attached file is a patch against berkeley/lpc.c to correct this.

Collaborator

michaelrsweet commented Dec 6, 2004

CUPS.org User: mike

Reassigned to 1.2.

"lpc status all" is a relatively new additional - older OS's did not support it (or at least it was undocumented...)

Collaborator

michaelrsweet commented Sep 16, 2005

CUPS.org User: mike

Fixed in Subversion repository.

Collaborator

michaelrsweet commented Sep 16, 2005

"cups-lpr__lpc.c__status_all.diff":

--- berkeley/lpc.c.orig Wed Feb 25 17:14:50 2004
+++ berkeley/lpc.c Mon Nov 15 17:54:38 2004
@@ -339,6 +339,15 @@
}

  /*
  •  \* A single 'all' printer name is special, meaning all printers.
    
  •  */
    
  •  if (dests != NULL && compare_strings(dests, "all", 3) == 0)
    
  •  {
    
  •    dests = NULL;
    
  •  }
    
  • /*
    
    • See if this is a printer we're interested in...
      */

michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment