New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to keep warning about ACLs #1532

Closed
michaelrsweet opened this Issue Apr 3, 2006 · 2 comments

Comments

Projects
None yet
1 participant
@michaelrsweet
Collaborator

michaelrsweet commented Apr 3, 2006

Version: 1.2rc1
CUPS.org User: twaugh.redhat

When /var/run/cups/certs/0 is on a filesystem that does not support POSIX ACLs, each time the certificate is renewed there is a new line added to error_log:

Unable to set ACLs on root certificate "/var/run/cups/certs/0" - Operation not supported

It's probably sufficient just to warn once, as in the attached patch.

@michaelrsweet

This comment has been minimized.

Collaborator

michaelrsweet commented Apr 7, 2006

CUPS.org User: mike

Commited with some formatting changes (to conform to our coding standards...)

@michaelrsweet

This comment has been minimized.

Collaborator

michaelrsweet commented Apr 7, 2006

"cups-acls.patch":

--- cups-1.2rc1/scheduler/cert.c.acls 2006-04-03 11:22:52.000000000 +0100
+++ cups-1.2rc1/scheduler/cert.c 2006-04-03 12:58:21.000000000 +0100
@@ -216,10 +216,16 @@
}

endif /* HAVE_MBR_UID_TO_UUID */

  •  if (acl_set_fd(fd, acl))
    
  • cupsdLogMessage(CUPSD_LOG_ERROR,
  •       "Unable to set ACLs on root certificate \"%s\" - %s",
    
  •       filename, strerror(errno));
    
  •  if (acl_set_fd(fd, acl)) {
    
  • static int acls_not_supported = 0; /* Only warn once */
  • if (errno != EOPNOTSUPP || !acls_not_supported)
  • cupsdLogMessage(CUPSD_LOG_ERROR,
    
  •         "Unable to set ACLs on root certificate \"%s\" - %s",
    
  •         filename, strerror(errno));
    
  • if (errno == EOPNOTSUPP)
  • acls_not_supported = 1;
    
  •  }
    
    • acl_free(acl);
      }
      #endif /* HAVE_ACL_INIT */

@michaelrsweet michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment