changing priority of pending jobs has no effect

[michaelrsweet]

Version: 1.2.1
CUPS.org User: dkastens.uos

When I change the priority of a pending job with the command "lp -i -q " (from 50 to 70 for example) the ranking of the queued jobs doesn't change.
cups-1.2.1-1 on RedHat EL AS 4.

[michaelrsweet]

CUPS.org User: mike

Actually, the problem seems to have been that the scheduler was sorting priority in ascending rather than descending order, so smaller values would cause the job to be printed first. The attached patch fixes things...

[michaelrsweet]

"str1811.patch":

Index: job.c

--- job.c (revision 5711)
+++ job.c (working copy)
@@ -1753,8 +1753,8 @@
int diff; /* Difference */

• if ((diff = ((cupsd_job_t *)first)->priority -

•          ((cupsd_job_t *)second)->priority) != 0)
  

• if ((diff = ((cupsd_job_t *)second)->priority -

•          ((cupsd_job_t *)first)->priority) != 0)
  

  return (diff);
  else
  return (((cupsd_job_t *)first)->id - ((cupsd_job_t *)second)->id);