pstops page-border patch #203

Closed
michaelrsweet opened this Issue Jul 25, 2003 · 2 comments

Comments

Projects
None yet
1 participant
Collaborator

michaelrsweet commented Jul 25, 2003

Version: 1.1-current
CUPS.org User: jlovell

Patchs attached for the following:

  • The recent change to pstops.c is missing 2 nots ('!') before strcasecmp.
  • Wrong name for dylib in filter/.cvsignore.
  • Compiler warning in ipp-var.c.
Collaborator

michaelrsweet commented Jul 25, 2003

CUPS.org User: mike

Thanks, applied to CVS...

Collaborator

michaelrsweet commented Jul 25, 2003

"cups_str203.patch":

? locale/.cvsignore

Index: cgi-bin/ipp-var.c

RCS file: /home/anoncvs/cups/cgi-bin/ipp-var.c,v
retrieving revision 1.36
diff -u -d -b -w -r1.36 ipp-var.c
--- cgi-bin/ipp-var.c 20 Jul 2003 03:35:04 -0000 1.36
+++ cgi-bin/ipp-var.c 25 Jul 2003 01:00:13 -0000
@@ -150,7 +150,7 @@
if (num_attrs > 0)
{
ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_KEYWORD,

  •              "requested-attributes", num_attrs, NULL, attrs);
    
  •              "requested-attributes", num_attrs, NULL, (const char **)attrs);
    

    for (i = 0; i < num_attrs; i ++)
    free(attrs[i]);

    Index: filter/.cvsignore

    RCS file: /home/anoncvs/cups/filter/.cvsignore,v
    retrieving revision 1.3
    diff -u -d -b -w -r1.3 .cvsignore
    --- filter/.cvsignore 26 Apr 2003 17:14:34 -0000 1.3
    +++ filter/.cvsignore 25 Jul 2003 01:00:13 -0000
    @@ -4,7 +4,7 @@
    imagetops
    imagetoraster
    libcupsimage.a
    -libcupsimage.dylib.2
    +libcupsimage.2.dylib
    libcupsimage_s.a
    libcupsimage.sl.2
    libcupsimage.so.2

    Index: filter/pstops.c

    RCS file: /home/anoncvs/cups/filter/pstops.c,v
    retrieving revision 1.103
    diff -u -d -b -w -r1.103 pstops.c
    --- filter/pstops.c 20 Jul 2003 02:01:49 -0000 1.103
    +++ filter/pstops.c 25 Jul 2003 01:00:14 -0000
    @@ -244,9 +244,9 @@

    if ((val = cupsGetOption("page-border", num_options, options)) != NULL)
    {

  • if (strcasecmp(val, "none"))

  • if (!strcasecmp(val, "none"))
    Border = BORDER_NONE;

  • else if (strcasecmp(val, "single"))

  • else if (!strcasecmp(val, "single"))
    Border = BORDER_SINGLE;
    else if (!strcasecmp(val, "single-thick"))
    Border = BORDER_SINGLE2;

michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment