New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

programming error? in snmp.c #2100

Closed
michaelrsweet opened this Issue Nov 14, 2006 · 1 comment

Comments

Projects
None yet
1 participant
@michaelrsweet
Collaborator

michaelrsweet commented Nov 14, 2006

Version: 1.2.6
CUPS.org User: kmuto.debian

Hi,
This STR is as same as Debian#397833,

backend/snmp.c line 1755-
if (http);
{
/*
* IPP is supported...
*/

It looks like the bracketed block is ment to be conditional on the
value of 'http'. But since there is this strange semicolon at the end
of the line with the 'if', the block is executed unconditionally.
I think that this is a bug and that the semicolon should be removed.

@michaelrsweet

This comment has been minimized.

Collaborator

michaelrsweet commented Nov 14, 2006

CUPS.org User: mike

It is an error, but thanks to how the CUPS APIs check for NULL values it just introduces inefficiency (building an IPP request that is never used) rather than crashing...

Fixed in trunk and 1.2...

@michaelrsweet michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment