Positioning error in pdftops filter with landscape pages #243

Closed
michaelrsweet opened this Issue Aug 24, 2003 · 2 comments

Comments

Projects
None yet
1 participant
Collaborator

michaelrsweet commented Aug 24, 2003

Version: 1.1.19
CUPS.org User: h.blischke

Landscape pages are positioned too far to the left (by the
amount of left plus right margin). The x-shift after the rotation has to be done by the paper width instead of the width of the imageable area. See the following diff:
---snip---
*** PSOutputDev.cxx Mi Mai 14 20:22:24 2003
--- new.PSOutputDev.cxx So Aug 24 20:14:25 2003


*** 1719,1725 ****
writePS("pdfStartPage\n");
writePS("90 rotate\n");
tx = -x1;
! ty = -(y1 + imageWidth);
t = width;
width = height;
height = t;
--- 1719,1725 ----
writePS("pdfStartPage\n");
writePS("90 rotate\n");
tx = -x1;
! ty = -(y1 + width);
t = width;
width = height;
height = t;
----snip----

Collaborator

michaelrsweet commented Aug 27, 2003

CUPS.org User: mike

Actually, you don't want to use "width", you want "globalParams->getPSPaperWidth()"... "width" is the imageable area which is usually less than the full width of the page.

We'll roll this into the pending updates for the pdftops filter for 1.1.20rc1.

Thanks for the report!

Collaborator

michaelrsweet commented Aug 28, 2003

CUPS.org User: mike

OK, a fix is in CVS now, along with support for unscaled/offset output (new "fitplot" support in the pdftops filter, with the default to not fit...)

michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment