Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The -p option of lpr does not work #2544

Closed
michaelrsweet opened this Issue Oct 3, 2007 · 1 comment

Comments

Projects
None yet
1 participant
@michaelrsweet
Copy link
Collaborator

michaelrsweet commented Oct 3, 2007

Version: 1.3.3
CUPS.org User: olsona

The -p option of the lpr command is supposed to be equivalent to
-oprettyprint, but it does nothing. This seems to be because of the use
of a "" argument in a CupsAddOption function call rather than a "true" argument. A proposed change appears below (and, while we're in the neighborhood, we'll make the same sort of change a couple of lines away).

    --ado

------- lpr.c -------
*** /tmp/geta2727 Wed Oct 3 09:10:53 2007
--- /tmp/getb2727 Wed Oct 3 09:10:53 2007


*** 200,210 ****
break;

case 'l' : /* Literal/raw */

! num_options = cupsAddOption("raw", "", num_options, &options);
break;

case 'p' : /* Prettyprint */

! num_options = cupsAddOption("prettyprint", "", num_options,
&options);
break;

--- 200,210 ----
break;

case 'l' : /* Literal/raw */

! num_options = cupsAddOption("raw", "true", num_options, &options);
break;

case 'p' : /* Prettyprint */

! num_options = cupsAddOption("prettyprint", "true", num_options,
&options);
break;

@michaelrsweet

This comment has been minimized.

Copy link
Collaborator Author

michaelrsweet commented Oct 10, 2007

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.