PJL: to return display to normal ready message, use "" instead of "READY" #2909

Closed
michaelrsweet opened this Issue Aug 16, 2008 · 5 comments

Comments

Projects
None yet
1 participant
Collaborator

michaelrsweet commented Aug 16, 2008

Version: 1.3-current
CUPS.org User: ion

According to the PJL spec[1], one should use "" (not "READY") to return the display to the normal ready message.

[1] http://h20000.www2.hp.com/bc/docs/support/SupportManual/bpl13208/bpl13208.pdf, page 160

The bug also concerns 1.3.8, and the patch applies cleanly to it.

Collaborator

michaelrsweet commented Aug 17, 2008

CUPS.org User: mike

Moving to CUPS 1.3.x...

Collaborator

michaelrsweet commented Aug 25, 2008

CUPS.org User: troy-eroesinger

Any workarounds (e.g., via PPD) for existing versions?

Collaborator

michaelrsweet commented Aug 26, 2008

CUPS.org User: mike

Fixed in Subversion repository.

Collaborator

michaelrsweet commented Aug 26, 2008

"pjl-display-ready-message.patch":

PJL display ready message

From: Johan Kiviniemi cups.org@johan.kiviniemi.name

According to the PJL spec, one should use "" (not "READY") to return the

display to the normal ready message.

cups/emit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cups/emit.c b/cups/emit.c
index 1f87460..c59f634 100644
--- a/cups/emit.c
+++ b/cups/emit.c
@@ -549,7 +549,7 @@ ppdEmitJCLEnd(ppd_file_t ppd, / I - PPD file record */
*/

 fputs("\033%-12345X@PJL\n", fp);
  • fputs("@pjl RDYMSG DISPLAY = "READY"\n", fp);
  • fputs("@pjl RDYMSG DISPLAY = ""\n", fp);
    fputs(ppd->jcl_end + 9, fp);
    }
    else
Collaborator

michaelrsweet commented Aug 26, 2008

"str2909.patch":

Index: cups/emit.c

--- cups/emit.c (revision 7860)
+++ cups/emit.c (working copy)
@@ -549,7 +549,7 @@
*/

 fputs("\033%-12345X@PJL\n", fp);
  • fputs("@pjl RDYMSG DISPLAY = "READY"\n", fp);
  • fputs("@pjl RDYMSG DISPLAY = ""\n", fp);
    fputs(ppd->jcl_end + 9, fp);
    }
    else

@michaelrsweet michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment