don't install xinetd file to /no if --without-xinetd is passed to configure #2970

Closed
michaelrsweet opened this Issue Oct 10, 2008 · 6 comments

Comments

Projects
None yet
1 participant
Collaborator

michaelrsweet commented Oct 10, 2008

Version: 1.3-current
CUPS.org User: impulze

if configure is passed --without-xinetd and $withval evaluates to no in config-scripts/cups-directories.m4 then the files are installed into /no which i think is not wanted. the applied patch sets XINETD to "" if withval is equal to "no"

Collaborator

michaelrsweet commented Oct 12, 2008

CUPS.org User: mike

This is actually a priority 2 bug, not a feature request...

Collaborator

michaelrsweet commented Oct 12, 2008

CUPS.org User: impulze

If so, I think I've found some more, e.g. rcdir and what not. If that's actually a bug I'll search for the other ones next weekend.

Collaborator

michaelrsweet commented Oct 19, 2008

CUPS.org User: impulze

nopes, that's about the only one, --without-rcdirs doesn't make any sense anyway, so...

Collaborator

michaelrsweet commented Oct 23, 2008

CUPS.org User: mike

Fixed in Subversion repository.

Collaborator

michaelrsweet commented Oct 23, 2008

"cups-xinetd.patch":

--- ./config-scripts/cups-directories.m4.bak 2008-10-10 16:32:32.000000000 +0200
+++ ./config-scripts/cups-directories.m4 2008-10-10 16:41:52.000000000 +0200
@@ -225,6 +225,8 @@
break
fi
done
+elif test "$XINETD" = no; then

  • XINETD=""
    fi

AC_SUBST(XINETD)

Collaborator

michaelrsweet commented Oct 23, 2008

"str2970.patch":

Index: config-scripts/cups-directories.m4

--- config-scripts/cups-directories.m4 (revision 8073)
+++ config-scripts/cups-directories.m4 (working copy)
@@ -201,7 +201,7 @@
;;

esac

-else
+elif test "x$rcdir" != xno; then
if test "x$rclevels" = x; then
INITDDIR="$rcdir"
else
@@ -225,6 +225,8 @@
break
fi
done
+elif test "x$XINETD" = xno; then

  • XINETD=""
    fi

AC_SUBST(XINETD)

michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment