mailto notifier broken sending to SMTP server #3011

Closed
michaelrsweet opened this Issue Nov 17, 2008 · 2 comments

Comments

Projects
None yet
1 participant
Collaborator

michaelrsweet commented Nov 17, 2008

Version: 1.3-current
CUPS.org User: opher

Configured to send through a SMTP server, the mailto notifier is broken.
It will start the exchange, timeout waiting for a response and enter an infinite loop sending "QUIT" to the error log.

This happens because at the end of the message body it sends ".\n" instead of ".\r\n"
Patch attached.

Regards.

Collaborator

michaelrsweet commented Nov 17, 2008

CUPS.org User: mike

Fixed in Subversion repository.

Strangely enough, this was already fixed in 1.4.x, not sure why the fix wasn't applied to 1.3.x...

Collaborator

michaelrsweet commented Nov 17, 2008

"mailto-smtpserver.patch":

This patch file was generated by NetBeans IDE

Following Index: paths are relative to: H:\My Documents\Projects\CUPS\cups-1.3.x\notifier

This patch can be applied using context Tools: Patch action on respective folder.

It uses platform neutral UTF-8 encoding and \n newlines.

Above lines and this line are ignored by the patching process.

Index: mailto.c
--- mailto.c Base (BASE)
+++ mailto.c Locally Modified (Based On LOCAL)
@@ -315,7 +315,7 @@
cupsFilePrintf(fp, "Content-Type: text/plain%s", nl);
cupsFilePuts(fp, nl);
cupsFilePrintf(fp, "%s%s", text, nl);

  • cupsFilePrintf(fp, ".\n", nl);
  • cupsFilePrintf(fp, ".%s", nl);

/*

  • Close the connection to the mail server...

michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment