Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for STR #2920 incomplete #3023

Closed
michaelrsweet opened this issue Nov 25, 2008 · 2 comments
Closed

Fix for STR #2920 incomplete #3023

michaelrsweet opened this issue Nov 25, 2008 · 2 comments

Comments

@michaelrsweet
Copy link
Collaborator

@michaelrsweet michaelrsweet commented Nov 25, 2008

Version: 1.3.9
CUPS.org User: twaugh.redhat

The fix for STR #2920 is incomplete. Here is a patch to fix that.

@michaelrsweet
Copy link
Collaborator Author

@michaelrsweet michaelrsweet commented Nov 27, 2008

CUPS.org User: mike

EAI_AGAIN is a non-fatal error and should just be retried (which I'm pretty sure we do, at least in the backends...) Reinitializing the whole stack is really the wrong thing to do.

EAI_NONAME errors are not cached, or at least they aren't supposed to be. If they are, that is a glibc bug.

Really don't want to take this patch, sorry...

@michaelrsweet
Copy link
Collaborator Author

@michaelrsweet michaelrsweet commented Nov 27, 2008

"cups-res_init.patch":

diff -up cups-1.3.9/cups/http-addrlist.c.res_init cups-1.3.9/cups/http-addrlist.c
--- cups-1.3.9/cups/http-addrlist.c.res_init 2008-11-25 17:48:44.000000000 +0000
+++ cups-1.3.9/cups/http-addrlist.c 2008-11-25 17:50:24.000000000 +0000
@@ -345,7 +345,7 @@ httpAddrGetList(const char hostname, /

   freeaddrinfo(results);
 }
  • else if (error == EAI_FAIL)
  • else if (error == EAI_FAIL || error == EAI_NONAME || error == EAI_AGAIN)
    cg->need_res_init = 1;

#else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant