New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
classes.conf not updated when class member is deleted #3505
Comments
CUPS.org User: mike This patch has the side-effect of always writing classes.conf, even if there are no classes (the most common case). Will look at updating cupsdDeletePrinterFromClasses so we can determine whether any classes were affected... |
CUPS.org User: mike OK, I've attached a different patch that updates all of the delete calls to return a status indicating whether a class was affected by the deletion. If so, we update classes.conf... |
CUPS.org User: mike Fixed in Subversion repository. |
"0001-Update-classes.conf-when-a-printer-is-deleted.patch": From eeaf0a8d52b0195a59546bc63aa1de26cf86de79 Mon Sep 17 00:00:00 2001 When a printer is deleted, classes.conf is never updated even if the Original report: https://bugzilla.redhat.com/show_bug.cgi?id=565823scheduler/ipp.c | 2 +- diff --git a/scheduler/ipp.c b/scheduler/ipp.c
/*1.6.6 |
"str3505.patch": Index: scheduler/classes.h--- scheduler/classes.h (revision 8995)
Index: scheduler/printers.c--- scheduler/printers.c (revision 8995)
-void
if (!(p->type & CUPS_PRINTER_IMPLICIT))
/*
cupsArrayRestore(Printers);
Index: scheduler/printers.h--- scheduler/printers.h (revision 8995) Index: scheduler/classes.c--- scheduler/classes.c (revision 8995)
-void
/*
cupsdSetPrinterAttrs(c);
@@ -163,10 +165,11 @@
-void
@@ -179,7 +182,7 @@
|
Version: 1.4.2
CUPS.org User: twaugh.redhat
When a printer is deleted, classes.conf is never updated even if the
printer was a member of a class.
Original report:
https://bugzilla.redhat.com/show_bug.cgi?id=565823
The text was updated successfully, but these errors were encountered: