Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory disclosure in CUPS with admin URLs #3577

Closed
michaelrsweet opened this issue May 5, 2010 · 3 comments

Comments

@michaelrsweet
Copy link
Collaborator

commented May 5, 2010

Version: 1.4-current
CUPS.org User: mike

See attached PDF, but in short, a URL like

http://127.0.0.1:631/admin?URL=/admin/&OP=%

will produce an error response that discloses a some uninitialised memory. This could be used to bypass ASLR, for example. The problem is in cgi-bin/var.c in cgi_initialize_string().

@michaelrsweet

This comment has been minimized.

Copy link
Collaborator Author

commented May 5, 2010

CUPS.org User: mike

Fix is attached.

@michaelrsweet

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 16, 2010

CUPS.org User: mike

Fixed in Subversion repository.

@michaelrsweet

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 16, 2010

"str3577.patch":

Index: cgi-bin/var.c

--- cgi-bin/var.c (revision 2161)
+++ cgi-bin/var.c (working copy)
@@ -1111,6 +1111,9 @@
* Read the hex code...
*/

  •        if (!isxdigit(data[1] & 255) || !isxdigit(data[2] & 255))
    
  •     return (0);
    
    •    if (s < (value + sizeof(value) - 1))
      
      {
      data ++;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.