CUPS daemon crashes on bad entry in cupsd.conf #4192

Closed
michaelrsweet opened this Issue Sep 26, 2012 · 2 comments

Comments

Projects
None yet
1 participant
Collaborator

michaelrsweet commented Sep 26, 2012

Version: 1.6.1
CUPS.org User: till.kamppeter

Original bug report in Ubuntu:

https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1036974

When updating Ubuntu to the current development version CUPS got updated from 1.5.3 to 1.6.1. Many users have the obsolete keywords BrowsePoll, BrowseAllow, BrowseDeny, BrowseOrder, and BrowseRemoteProtocols or the obsolete argument "cups" for the still valid BrowseLocalProtocols keyword in their cupsd.conf.

At least the obsolete (or perhaps any invalid/mistyped) keywords cause the CUPS daemon to crash. What I expect is that simply an error gets reported in error_log.

Stack traces of the crash are attached to the Ubuntu bug report:

https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1036974/+attachment/3261809/+files/Stacktrace.txt
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1036974/+attachment/3261811/+files/ThreadStacktrace.txt

Collaborator

michaelrsweet commented Oct 1, 2012

CUPS.org User: mike

Till, can you try this patch out? It should prevent the crash from happening (where DNSSDMaster is not NULL but DNSSDClient is NULL) but since I can't reproduce it...

Collaborator

michaelrsweet commented Oct 10, 2012

"str4192.patch":

Index: scheduler/dirsvc.c

--- scheduler/dirsvc.c (revision 10624)
+++ scheduler/dirsvc.c (working copy)
@@ -234,9 +234,12 @@

     if (FatalErrors & CUPSD_FATAL_BROWSE)
  cupsdEndProcess(getpid(), 0);
  •    avahi_threaded_poll_free(DNSSDMaster);
    
  •    DNSSDMaster = NULL;
    

    }

  •  avahi_threaded_poll_start(DNSSDMaster);
    
  •  else
    
  • avahi_threaded_poll_start(DNSSDMaster);
    }

endif /* HAVE_DNSSD */

michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment