ipp backend endless loop #4194

Closed
michaelrsweet opened this Issue Sep 27, 2012 · 3 comments

Comments

Projects
None yet
1 participant
Collaborator

michaelrsweet commented Sep 27, 2012

Version: 1.5.4
CUPS.org User: krumboeck

The ipp backend could hang, when connection failed.

Error log:
D [27/Sep/2012:09:04:07 +0200] [Job 486392] Getting supported attributes...
D [27/Sep/2012:09:04:07 +0200] [Job 486392] Get-Printer-Attributes: server-error-internal-error (Connection reset by peer)
D [27/Sep/2012:09:04:07 +0200] [Job 486392] Get-Printer-Attributes returned server-error-internal-error.
E [27/Sep/2012:09:04:07 +0200] [Job 486392] Unable to get printer status.

Restoring the connection and restarting the ipp service on the other side didn't help.

Please check the attached patch.

Collaborator

michaelrsweet commented Oct 1, 2012

CUPS.org User: mike

Fixed in Subversion repository.

Collaborator

michaelrsweet commented Oct 1, 2012

"cups-1.5.4-ipp-reconnect.patch":

--- backend/ipp.c.orig 2012-09-27 18:23:17.000000000 +0200
+++ backend/ipp.c 2012-09-27 18:26:29.000000000 +0200
@@ -923,6 +923,9 @@
_cupsLangPrintFilter(stderr, "ERROR",
_("Unable to get printer status."));
sleep(10);

  •    if (ipp_status == IPP_INTERNAL_ERROR) {
    
  • httpReconnect(http);
    
  •    }
    

    }

    ippDelete(supported);

Collaborator

michaelrsweet commented Oct 1, 2012

"str4194.patch":

Index: backend/ipp.c

--- backend/ipp.c (revision 10619)
+++ backend/ipp.c (working copy)
@@ -952,6 +952,8 @@
_cupsLangPrintFilter(stderr, "ERROR",
_("Unable to get printer status."));
sleep(10);
+

  • httpReconnect(http);
    }

    ippDelete(supported);

michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment