old control files (c*.O) left in var/spool/cups #4244

Closed
michaelrsweet opened this Issue Dec 5, 2012 · 2 comments

Comments

Projects
None yet
1 participant
Collaborator

michaelrsweet commented Dec 5, 2012

Version: 1.6.1
CUPS.org User: pconklin

with job-history turned off, old control files persist forever in /var/spool/cups with a .O extension

[root@localhost cups]# lpadmin -ppaul -vfile:///dev/null -E
[root@localhost cups]# pwd
/var/spool/cups
[root@localhost cups]# ls
tmp
[root@localhost cups]# cupsdisable paul
[root@localhost cups]# lp -dpaul /etc/hosts
request id is paul-335 (1 file(s))
[root@localhost cups]# ls
c00335 c00335.O d00335-001 tmp
[root@localhost cups]# cupsenable paul
[root@localhost cups]# ls
c00335.O tmp

Collaborator

michaelrsweet commented Dec 12, 2012

CUPS.org User: mike

Fixed in Subversion repository.

Collaborator

michaelrsweet commented Dec 12, 2012

"str4244.patch":

Index: scheduler/job.c

--- scheduler/job.c (revision 10752)
+++ scheduler/job.c (working copy)
@@ -2193,7 +2193,16 @@
}

if (!cupsdCloseCreatedConfFile(fp, filename))

  • {
  • /*
  • * Remove backup file and mark this job as clean...
  • */
  • strlcat(filename, ".O", sizeof(filename));
  • unlink(filename);

job->dirty = 0;

  • }
    }

michaelrsweet added this to the Stable milestone Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment