New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove adding document-name from cups-lpd #4790

Closed
frazhome opened this Issue Mar 20, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@frazhome

frazhome commented Mar 20, 2016

since cups 1.6 this attribute throws warnings at error_log.

remove the code
if (docname[0])
ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "document-name",
NULL, docname);

at cups-lpd.c line 364 .

@michaelrsweet

This comment has been minimized.

Collaborator

michaelrsweet commented Mar 21, 2016

What warning are you seeing? Because document-name is a valid attribute and I do not see any code that would specifically warn about its use...

@frazhome

This comment has been minimized.

frazhome commented Mar 21, 2016

each printjob received via lpd create such a message:
W [21/Mar/2016:09:27:01 +0100] Unexpected 'document-name' operation attribute in a Create-Job request.

http://marc.info/?l=cups&m=134556471411674&w=2

this message is created at cups/scheduler/ipp.c
'create_job()' - Print a file to a printer or class.
Line 5124 - 5200

@michaelrsweet michaelrsweet added this to the Stable milestone Mar 24, 2016

@michaelrsweet michaelrsweet self-assigned this Mar 24, 2016

@michaelrsweet

This comment has been minimized.

Collaborator

michaelrsweet commented Mar 24, 2016

Fixed.

[master 961a8a3] The cups-lpd mini-daemon incorrectly included the document-name attribute when creating a job. It should only be included when sending a job (Issue #4790)

[branch-2.1 4cc64a8] Mirror fix from master.

michaelrsweet pushed a commit that referenced this issue Mar 24, 2016

Michael R Sweet
The cups-lpd mini-daemon incorrectly included the document-name attri…
…bute when

creating a job.  It should only be included when sending a job (Issue #4790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment