Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.9 lpadmin -E regression for raw printers ? #5440

Closed
OdyX opened this issue Nov 18, 2018 · 5 comments

Comments

@OdyX
Copy link
Contributor

commented Nov 18, 2018

After uploading 2.2.9 to Debian unstable, the CI runner (which run a test on an installed CUPS instance) started to fail: https://ci.debian.net/packages/c/cups/testing/amd64/

Specifically: https://ci.debian.net/data/autopkgtest/testing/amd64/c/cups/1329969/log.gz

The following command is launched:

lpadmin -p test-printer0 -E -m raw -v file:///dev/null

It spits "incorrect request" and the printer is not created, but reading from the logs didn't allow me to understand why.

This only started to fail in 2.2.9; and running lpadmin without the -E then cupsenable seems to work.

What has changed?

@michaelrsweet

This comment has been minimized.

Copy link
Collaborator

commented Nov 18, 2018

This could be a regression caused by the fix for Issue #5305.

@michaelrsweet michaelrsweet self-assigned this Nov 18, 2018

@OdyX

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

Indeed. Reverting both a83658f and 2b4e4ed fixes this. No good idea how to go forward with this though.

@michaelrsweet

This comment has been minimized.

Copy link
Collaborator

commented Nov 26, 2018

I'll need to trace things through to make sure we are still creating the queue properly. Raw support has been deprecated, of course, but it is still supposed to work...

@michaelrsweet michaelrsweet added this to the CUPS 2.2.x Updates milestone Nov 26, 2018

@michaelrsweet michaelrsweet added P2 - Low and removed Unconfirmed labels Nov 26, 2018

@michaelrsweet

This comment has been minimized.

Copy link
Collaborator

commented Nov 26, 2018

(and I've been able to reproduce locally, at least, so we'll see where this goes...)

michaelrsweet added a commit that referenced this issue Dec 5, 2018
michaelrsweet added a commit that referenced this issue Dec 5, 2018
@michaelrsweet

This comment has been minimized.

Copy link
Collaborator

commented Dec 5, 2018

[master c29d06f] Fix -E option (Issue #5440)

[branch-2.2 d3cfe06] Fix -E option (Issue #5440)

OdyX added a commit to OdyX/cups that referenced this issue May 7, 2019
OdyX added a commit to OdyX/cups that referenced this issue May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.