From db1343cf83a8ffb33d68a439ab2ef0f16ab013c9 Mon Sep 17 00:00:00 2001
From: Donghao Ren <donghao.ren@gmail.com>
Date: Fri, 21 Nov 2025 23:00:33 -0800
Subject: [PATCH 1/2] fix: scroll dashboard to new chart on adding a new chart
 with plus button

---
 .../dashboard/DashboardChartPanel.svelte      |  7 ++++++
 .../layouts/dashboard/DashboardLayout.svelte  | 25 ++++++++++++++++++-
 2 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/packages/viewer/src/layouts/dashboard/DashboardChartPanel.svelte b/packages/viewer/src/layouts/dashboard/DashboardChartPanel.svelte
index 72d4d30..ebf11b7 100644
--- a/packages/viewer/src/layouts/dashboard/DashboardChartPanel.svelte
+++ b/packages/viewer/src/layouts/dashboard/DashboardChartPanel.svelte
@@ -63,6 +63,8 @@
 
   let editingSpec = $state.raw<any | undefined>();
 
+  let container: HTMLDivElement;
+
   function dragHandler(mask: [number, number, number, number]) {
     return (e1: CursorValue) => {
       let numColumns = grid.numColumns;
@@ -115,11 +117,16 @@
       };
     };
   }
+
+  export function scrollIntoView() {
+    container?.scrollIntoView({ block: "nearest" });
+  }
 </script>
 
 <!-- svelte-ignore a11y_no_static_element_interactions -->
 <!-- svelte-ignore a11y_click_events_have_key_events -->
 <div
+  bind:this={container}
   class="absolute"
   style:left="{x}px"
   style:top="{y}px"
diff --git a/packages/viewer/src/layouts/dashboard/DashboardLayout.svelte b/packages/viewer/src/layouts/dashboard/DashboardLayout.svelte
index d40aa02..0cd442c 100644
--- a/packages/viewer/src/layouts/dashboard/DashboardLayout.svelte
+++ b/packages/viewer/src/layouts/dashboard/DashboardLayout.svelte
@@ -1,6 +1,6 @@
 <!-- Copyright (c) 2025 Apple Inc. Licensed under MIT License. -->
 <script lang="ts">
-  import { untrack } from "svelte";
+  import { onMount, untrack } from "svelte";
   import { fade } from "svelte/transition";
 
   import DashboardChartPanel from "./DashboardChartPanel.svelte";
@@ -75,6 +75,7 @@
   });
 
   function removeChart(id: string) {
+    onStateChange({ grids: { [gridKey]: { placements: { ...placements, [id]: undefined as any } } } });
     onChartsChange({ [id]: undefined });
     onChartStatesChange({ [id]: undefined });
   }
@@ -90,6 +91,27 @@
     onChartsChange({ [id]: { type: "builder", title: "New" } });
     onStateChange({ grids: { [gridKey]: { placements: { [id]: placement } } } });
   }
+
+  let chartPanels = $state<Record<string, DashboardChartPanel | null>>({});
+  onMount(() => {
+    let chartIDs = new Set(Object.keys(charts));
+    $effect(() => {
+      let oldIDs = chartIDs;
+      chartIDs = new Set(Object.keys(charts));
+      if (chartIDs.size != oldIDs.size + 1) {
+        return;
+      }
+      let diff: string[] = [];
+      for (let id of chartIDs) {
+        if (!oldIDs.has(id)) {
+          diff.push(id);
+        }
+      }
+      if (diff.length == 1) {
+        chartPanels[diff[0]]?.scrollIntoView();
+      }
+    });
+  });
 </script>
 
 <div
@@ -123,6 +145,7 @@
 
     {#each Object.keys(charts) as id (id)}
       <DashboardChartPanel
+        bind:this={chartPanels[id]}
         context={context}
         id={id}
         spec={charts[id]}

From 6d84cf17f04a28d963e296fae8378c360b8c1746 Mon Sep 17 00:00:00 2001
From: Donghao Ren <donghao.ren@gmail.com>
Date: Fri, 21 Nov 2025 23:04:32 -0800
Subject: [PATCH 2/2] Copyright headers

---
 packages/viewer/src/charts/builder/ConfirmButton.svelte | 1 +
 packages/viewer/src/charts/common/plot_layout.ts        | 2 ++
 packages/viewer/src/charts/common/solve_extents.ts      | 2 ++
 3 files changed, 5 insertions(+)

diff --git a/packages/viewer/src/charts/builder/ConfirmButton.svelte b/packages/viewer/src/charts/builder/ConfirmButton.svelte
index 4352b30..df39800 100644
--- a/packages/viewer/src/charts/builder/ConfirmButton.svelte
+++ b/packages/viewer/src/charts/builder/ConfirmButton.svelte
@@ -1,3 +1,4 @@
+<!-- Copyright (c) 2025 Apple Inc. Licensed under MIT License. -->
 <script lang="ts">
   interface Props {
     label: string;
diff --git a/packages/viewer/src/charts/common/plot_layout.ts b/packages/viewer/src/charts/common/plot_layout.ts
index da2e2be..92ee523 100644
--- a/packages/viewer/src/charts/common/plot_layout.ts
+++ b/packages/viewer/src/charts/common/plot_layout.ts
@@ -1,3 +1,5 @@
+// Copyright (c) 2025 Apple Inc. Licensed under MIT License.
+
 import { solveExtents } from "./solve_extents.js";
 import type { IntermediatePositionScale, PlotLayout } from "./types.js";
 
diff --git a/packages/viewer/src/charts/common/solve_extents.ts b/packages/viewer/src/charts/common/solve_extents.ts
index 2f35054..3b42af0 100644
--- a/packages/viewer/src/charts/common/solve_extents.ts
+++ b/packages/viewer/src/charts/common/solve_extents.ts
@@ -1,3 +1,5 @@
+// Copyright (c) 2025 Apple Inc. Licensed under MIT License.
+
 export function solveExtents(
   data: [number, number][],
   length: number,