From b685691629c7c08dae732602e77e0fd506a327d4 Mon Sep 17 00:00:00 2001 From: Zhe Wang Date: Fri, 18 Jun 2021 20:59:48 -0500 Subject: [PATCH] add trace event to recovery_transaction step in recovery --- fdbserver/masterserver.actor.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/fdbserver/masterserver.actor.cpp b/fdbserver/masterserver.actor.cpp index fe13a993708..792cce7ae67 100644 --- a/fdbserver/masterserver.actor.cpp +++ b/fdbserver/masterserver.actor.cpp @@ -294,7 +294,9 @@ ACTOR Future newCommitProxies(Reference self, RecruitFromConfi req.recoveryCount = self->cstate.myDBState.recoveryCount + 1; req.recoveryTransactionVersion = self->recoveryTransactionVersion; req.firstProxy = i == 0; - TraceEvent("CommitProxyReplies", self->dbgid).detail("WorkerID", recr.commitProxies[i].id()); + TraceEvent("CommitProxyReplies", self->dbgid) + .detail("WorkerID", recr.commitProxies[i].id()) + .detail("FirstProxy", req.firstProxy ? "True" : "False"); initializationReplies.push_back( transformErrors(throwErrorOr(recr.commitProxies[i].commitProxy.getReplyUnlessFailedFor( req, SERVER_KNOBS->TLOG_TIMEOUT, SERVER_KNOBS->MASTER_FAILURE_SLOPE_DURING_RECOVERY)), @@ -953,6 +955,10 @@ ACTOR Future sendInitialCommitToResolvers(Reference self) { wait(yield()); } wait(waitForAll(txnReplies)); + TraceEvent("RecoveryInternal", self->dbgid) + .detail("StatusCode", RecoveryStatus::recovery_transaction) + .detail("Status", RecoveryStatus::names[RecoveryStatus::recovery_transaction]) + .detail("Step", "SentTxnStateStoreToCommitProxies"); vector> replies; for (auto& r : self->resolvers) { @@ -965,6 +971,10 @@ ACTOR Future sendInitialCommitToResolvers(Reference self) { } wait(waitForAll(replies)); + TraceEvent("RecoveryInternal", self->dbgid) + .detail("StatusCode", RecoveryStatus::recovery_transaction) + .detail("Status", RecoveryStatus::names[RecoveryStatus::recovery_transaction]) + .detail("Step", "InitializedAllResolvers"); return Void(); }