Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove C-style variadic function in TLS code #433

Closed
AlvinMooreSr opened this issue Jun 4, 2018 · 0 comments
Closed

Remove C-style variadic function in TLS code #433

AlvinMooreSr opened this issue Jun 4, 2018 · 0 comments
Assignees
@AlvinMooreSr
Milestone
6.0

Comments

@AlvinMooreSr
Copy link
Contributor

Currently a C-style variadic function is used in TLSConnectionLogFunc in TLSConnection.actor.cpp. C-style variadic functions are not safe to write for a variety of reasons, and we should change this code to not use one. As an example, a bug has exists for some time which produced technically undefined behavior (passing a bool parameter to va_start).
@AlvinMooreSr AlvinMooreSr self-assigned this Jun 4, 2018
This was referenced Jun 12, 2018
Closed
Merged
@alexmiller-apple alexmiller-apple added this to the 6.0 milestone Jul 9, 2018
@AlvinMooreSr AlvinMooreSr mentioned this issue Jul 12, 2018
Merged
@hgray1 hgray1 closed this as completed Jul 16, 2018
sfc-gh-jfu pushed a commit to sfc-gh-jfu/foundationdb that referenced this issue Jul 20, 2023
@sfc-gh-sporwal
FDBCORE-5312: FrostdbCI build_image job should get triggered on any c…
85020e1 
…hange in contrib/build_image/ path (apple#433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlvinMooreSr AlvinMooreSr

Labels
None yet
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
3 participants
@alexmiller-apple @AlvinMooreSr @hgray1