New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 compatibility #830

Closed
amirouche opened this Issue Oct 9, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@amirouche
Copy link

amirouche commented Oct 9, 2018

5.2.5 bindings are not compatible with python 3.7:

amirouche@neitram:~/tmp/foundationdb-5.2.5$ /home/amirouche/.pyenv/versions/3.7.0/bin/python -m fdb.impl
Traceback (most recent call last):
  File "/home/amirouche/.pyenv/versions/3.7.0/lib/python3.7/runpy.py", line 183, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/home/amirouche/.pyenv/versions/3.7.0/lib/python3.7/runpy.py", line 153, in _get_module_details
    code = loader.get_code(mod_name)
  File "<frozen importlib._bootstrap_external>", line 860, in get_code
  File "<frozen importlib._bootstrap_external>", line 791, in source_to_code
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/amirouche/tmp/foundationdb-5.2.5/fdb/impl.py", line 1525
    self.async = gevent.get_hub().loop.async()
             ^
SyntaxError: invalid syntax

This particular error is raised because python 3.7 makes async (and await) reserved keywords.

@ajbeamon ajbeamon self-assigned this Oct 9, 2018

@ajbeamon

This comment has been minimized.

Copy link
Contributor

ajbeamon commented Oct 9, 2018

PR submitted: #831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment