JSON output options for fdbbackup status and describe #1248
Conversation
…age indicator to snapshot details.
fdbclient/FileBackupAgent.actor.cpp
Outdated
| @@ -4127,7 +4130,7 @@ class FileBackupAgentImpl { | |||
| Reference<IBackupContainer> bc = wait(backupConfig.backupContainer().getOrThrow(cx)); | |||
|
|
|||
| TraceEvent("AS_StartRestore"); | |||
| Version ver = wait( restore(backupAgent, cx, tagName, KeyRef(bc->getURL()), ranges, true, -1, true, addPrefix, removePrefix, true, randomUid) ); | |||
| Version ver = wait( restore(backupAgent, cx, cx, tagName, KeyRef(bc->getURL()), ranges, true, -1, true, addPrefix, removePrefix, true, randomUid) ); | |||
There was a problem hiding this comment.
I think you meant ... cx, cxOrig, ...
There was a problem hiding this comment.
No, atomicRestore() is a backup/restore test that uses a single database which is both the source of a backup and the destination for a restore of that backup. It takes a single database handle with a running backup, locks the database, completes the backup, restores the backup, then unlocks the database.
…. Added epochs field to JSON objects describing versions and timestamps in backup status and describe output, renamed some fields for clarity.
…nged Epochs to EpochSeconds in backup JSON along with some other renaming/moving of fields, and added information about snapshot dispatch. Changed timestamp format for input/output in all backup/restore contexts to be a fully qualified time with timezone offset. Added information about the last snapshot dispatch to backup config and status (not yet populated).
…r so status can determine if a snapshot is lagging the configured speed.
…e human readable status version.
…reaks compatibility with existing tooling.
…de by zero if the snapshot scheduled interval is 0.
| KeyBackedProperty<Version> snapshotDispatchLastVersion() { | ||
| return configSpace.pack(LiteralStringRef(__FUNCTION__)); | ||
| } | ||
|
|
There was a problem hiding this comment.
These two new properties are not being read in this PR. I see that they are cleared in one place but i could not spot any reads of these properties. Am i missing something?
There was a problem hiding this comment.
Yes, it is read in FileBackupAgent.actor.cpp, which is where the JSON status is generated. You probably just need to click "load diff" on that file, it's large enough that GitHub hides it by default.
…ckup status JSON, the document was being created outside the transaction retry loop so retries would combine partial element sets across all tries into the result.
…db into feature-backup-json
|
Added schema versions, and along the way noticed and fixed a bug. |
|
|
||
| loop { | ||
| try { | ||
| state JsonBuilderObject doc; | ||
| doc.setKey("SchemaVersion", "1.0.0"); |
There was a problem hiding this comment.
Define a constant 'SchemaVersion' instead of using "1.0.0." in multiple places.
There was a problem hiding this comment.
The two document formats are independent, one is for description of data in a backup and the other is status about running backups. They will evolve independently.
JSON output options for fdbbackup status and describe
JSON output options for fdbbackup status and describe
JSON output options for fdbbackup status and describe
This adds a --json option for
fdbbackup statusandfdbbackup describe. The main thing to review here is the JSON structure, as once tooling begins to rely on it it becomes unpleasant to change.Describe example:
Status examples: