Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tls plugin #343

Merged
merged 9 commits into from May 9, 2018

Conversation

Projects
None yet
3 participants
@bnamasivayam
Copy link
Contributor

commented May 9, 2018

Integrate new tls plugin and add https support for backup

@bnamasivayam bnamasivayam requested a review from etschannen May 9, 2018

{ TLSOptions::OPT_TLS_VERIFY_PEERS, TLS_VERIFY_PEERS_FLAG, SO_REQ_SEP },
{ TLSOptions::OPT_TLS_VERIFY_PEERS, TLS_VERIFY_PEERS_FLAG, SO_REQ_SEP }, \
{ TLSOptions::OPT_TLS_PASSWORD, TLS_PASSWORD_FLAG, SO_REQ_SEP }, \
{ TLSOptions::OPT_TLS_CA_FILE, TLS_CA_FILE_FLAG, SO_REQ_SEP },

This comment has been minimized.

Copy link
@etschannen

etschannen May 9, 2018

Contributor

The white space seems wrong

@bnamasivayam bnamasivayam requested a review from satherton May 9, 2018

description="Set the ca bundle" />
<Option name="TLS_ca_path" code="53"
paramType="String" paramDescription="file path"
description="Set the file from which to load the certificate authority bundle" />

This comment has been minimized.

Copy link
@alexmiller-apple

alexmiller-apple May 9, 2018

Contributor

Inconsistent indenting


TLSOptions() : certs_set(false), key_set(false), verify_peers_set(false) {}
enum { OPT_TLS = 100000, OPT_TLS_PLUGIN, OPT_TLS_CERTIFICATES, OPT_TLS_KEY, OPT_TLS_VERIFY_PEERS, OPT_TLS_CA_FILE };
enum POLICY_TYPE { POLICY_VERIFY_PEERS = 1, POLICY_NO_VERIFY_PEERS };

This comment has been minimized.

Copy link
@alexmiller-apple

alexmiller-apple May 9, 2018

Contributor

s/POLICY_TYPE/PolicyType/, and preferably enum class.


void register_network();

Reference<ITLSPolicy> get_policy();
Reference<ITLSPolicy> get_policy(enum POLICY_TYPE type);

This comment has been minimized.

Copy link
@alexmiller-apple

alexmiller-apple May 9, 2018

Contributor

enum POLICY_TYPE -> PolicyType.

Addressed review comments.
Remove redundant FDBLibTLS/ITLSPlugin.h.

@etschannen etschannen merged commit d3450ce into apple:release-5.2 May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.