New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TLS_plugin option. #710

Merged
merged 3 commits into from Aug 27, 2018

Conversation

Projects
None yet
2 participants
@ajbeamon
Copy link
Contributor

ajbeamon commented Aug 15, 2018

Also, don't remove deprecated methods from Go bindings, since that breaks compatibility with old API versions.

Deprecate TLS_plugin option. Don't remove deprecated methods from Go …
…bindings, since that breaks compatibility with old API versions.

@ajbeamon ajbeamon requested a review from alecgrieser Aug 15, 2018

@alecgrieser

This comment has been minimized.

Copy link
Contributor

alecgrieser commented Aug 15, 2018

This looks good to me, except that I noticed that this was done against the release-6.0 branch. It's somewhat academic given that the TLS plugin is already a no-op on 6.0, but should this be against master instead (just because it seems to go against the grain of semantic versioning to deprecate something with a patch)?

@ajbeamon

This comment has been minimized.

Copy link
Contributor

ajbeamon commented Aug 15, 2018

I think this just properly documents what already occurred in 6.0, so my vote would be to keep it here

@alecgrieser

This comment has been minimized.

Copy link
Contributor

alecgrieser commented Aug 15, 2018

Yeah, I definitely agree that if we had a time machine and could have done this patch prior to releasing 6.0.0, we should have done it (because you're right that the TLS plugin option was effectively deprecated then if not actually deprecated). I'm somewhat concerned about, say, Java users who run with settings that fail compilation when calling a deprecated API (which isn't that uncommon a setting, I don't think). Maybe that's not such a big problem, though.

@ajbeamon

This comment has been minimized.

Copy link
Contributor

ajbeamon commented Aug 15, 2018

Yeah, Java is the only case where I think this is noticeable, but I'm not personally that concerned about this particular effect. Though if anyone feels strongly, I could possibly be persuaded otherwise.

@ajbeamon ajbeamon merged commit f47b45c into apple:release-6.0 Aug 27, 2018

@ajbeamon ajbeamon deleted the ajbeamon:deprecate-tls-plugin-option branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment