Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Deprecate TLS_plugin option. #710
This looks good to me, except that I noticed that this was done against the release-6.0 branch. It's somewhat academic given that the TLS plugin is already a no-op on 6.0, but should this be against master instead (just because it seems to go against the grain of semantic versioning to deprecate something with a patch)?
Yeah, I definitely agree that if we had a time machine and could have done this patch prior to releasing 6.0.0, we should have done it (because you're right that the TLS plugin option was effectively deprecated then if not actually deprecated). I'm somewhat concerned about, say, Java users who run with settings that fail compilation when calling a deprecated API (which isn't that uncommon a setting, I don't think). Maybe that's not such a big problem, though.