Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: status would generate invalid json #758
left a comment
While this problem is not new, the changes here highlight how JsonString is not very type safe, and we should fix that now before merging this.
Functions for adding to it make assumptions about what has been added to it before, but the class does not enforce that these assumptions are correct so it must be used very carefully or it will generate invalid JSON. Since there are so many places that use the class, it's hard to verify that all usages are in line with these assumptions. A comparison of code coverage events for status schema validation between 6.0.9 and current suggest that not all usages are correct.