New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDBMonitor will only kill its entire process group on exit if it star… #826

Merged
merged 4 commits into from Nov 12, 2018

Conversation

Projects
None yet
3 participants
@satherton
Copy link
Contributor

satherton commented Oct 8, 2018

…ted its own process group with setsid() (as with daemonize mode), otherwise it will kill its processes individually.

#529

satherton added some commits Oct 8, 2018

FDBMonitor will only kill its entire process group on exit if it star…
…ted its own process group with setsid() (as with daemonize mode), otherwise it will kill its processes individually.

@satherton satherton requested a review from ajbeamon Oct 8, 2018

@ajbeamon
Copy link
Contributor

ajbeamon left a comment

These changes look ok to me. How have you tested them?

satherton added some commits Nov 8, 2018

Bug fix, kill_process() modifies the id <-> pid maps so to kill all i…
…ds one by one the loop iterator must be advanced before the kill.
@satherton

This comment has been minimized.

Copy link
Contributor

satherton commented Nov 9, 2018

Manual testing found a bug when the child process count is >1. Fixed.

@etschannen

This comment has been minimized.

Copy link
Contributor

etschannen commented Nov 12, 2018

Steve addressed the testing issues

@etschannen etschannen merged commit 380e7f9 into apple:release-6.0 Nov 12, 2018

satherton added a commit to satherton/foundationdb that referenced this pull request Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment