New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes related to changing region configurations #907

Merged
merged 7 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@etschannen
Copy link
Contributor

etschannen commented Nov 12, 2018

No description provided.

etschannen added some commits Nov 11, 2018

fix: if a destination team became unhealthy and then healthy again, i…
…t would lower the priority of a move even though the source servers we are moving from are still unhealthy

fix: badTeams were not accounted for when checking priorities
fix: Do not remove the locality entry for the current transaction log…
…s when removing storage servers

fix: dcId_locality map could be incorrect after restarting recruitEverything
fix: peek local should not call peek all, because it is possible to s…
…till peek from remote log sets after a special tag
fix: we do not know a region is fully replicated until all the initia…
…l storage servers have either been heard from or have been removed
@@ -154,9 +154,10 @@ class ShardsAffectedByTeamFailure : public ReferenceCounted<ShardsAffectedByTeam

int getNumberOfShards( UID ssID );
vector<KeyRange> getShardsFor( Team team );
vector<Team> getTeamsFor( KeyRangeRef keys );
std::pair<vector<Team>,vector<Team>> getTeamsFor( KeyRangeRef keys );

This comment has been minimized.

@alexmiller-apple

alexmiller-apple Nov 13, 2018

Contributor

comment which is which

@@ -167,7 +168,7 @@ class ShardsAffectedByTeamFailure : public ReferenceCounted<ShardsAffectedByTeam
}
};

KeyRangeMap< vector<Team> > shard_teams; // A shard can be affected by the failure of multiple teams if it is a queued merge
KeyRangeMap< std::pair<vector<Team>,vector<Team>> > shard_teams; // A shard can be affected by the failure of multiple teams if it is a queued merge

This comment has been minimized.

@alexmiller-apple

alexmiller-apple Nov 13, 2018

Contributor

update comment

extern const KeyRangeRef datacenterReplicasKeys;
extern const KeyRef datacenterReplicasPrefix;
const Key datacenterReplicasKeyFor( Optional<Value> dcID );
const Value datacenterReplicasValue( int const& );
Optional<Value> decodeDatacenterReplicasKey( KeyRef const& );
int decodeDatacenterReplicasValue( ValueRef const& );

// "\xff\x02/TLogDatacenters/[[datacenterID]]"

This comment has been minimized.

@alexmiller-apple

alexmiller-apple Nov 13, 2018

Contributor

Capitalization is wrong

@alexmiller-apple alexmiller-apple merged commit 5b14937 into apple:release-6.0 Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment