New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support integers up to 255 bytes in Go and Ruby #915

Merged
merged 16 commits into from Nov 13, 2018

Conversation

Projects
None yet
4 participants
@alecgrieser
Copy link
Contributor

alecgrieser commented Nov 13, 2018

This is a copy of #889, which I wanted to make changes to but proved unable to. Alas.

ajbeamon and others added some commits Oct 24, 2018

Merge branch 'tuple-uint64' into feature-bigint-support-go-ruby
# Conflicts:
#	bindings/go/src/fdb/tuple/tuple.go
Some fixes to the type chosen for decoding integers in Go. Fix to rub…
…y encoding at byte boundaries. Add execute bit to ruby tester.
@alecgrieser

This comment has been minimized.

Copy link
Contributor

alecgrieser commented Nov 13, 2018

@etschannen I mentioned this PR to you in person. The only new stuff that hasn't been looked over by other people is 3c8347e, so if you could take a look at that, that would be great. Also, another look at the release notes would be good.

@alecgrieser

This comment has been minimized.

Copy link
Contributor

alecgrieser commented Nov 13, 2018

Merging after @etschannen's review

@alecgrieser alecgrieser merged commit 4afccb4 into apple:release-6.0 Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment