Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt ArgumentParser for the command-line tool #72

Open
wants to merge 1 commit into
base: master
from

Conversation

@natecook1000
Copy link
Member

natecook1000 commented Feb 27, 2020

This adopts the new ArgumentParser library for parsing command-line arguments.

@benlangmuir

This comment has been minimized.

Copy link
Member

benlangmuir commented Feb 28, 2020

Hey @natecook1000 this looks really nice. My preference would be to wait until SwiftPM adopts ArgumentParser, then adopt it in sourcekit-lsp and indexstore-db. Until we're using it across the board in sourcekit-lsp+swiftpm, introducing a new dependency creates integration headaches for us that outweigh the benefits in this case (since this is only a tiny test executable).

I'd be happy to keep this PR open until we're ready to take it. Thanks again for the PR

@natecook1000

This comment has been minimized.

Copy link
Member Author

natecook1000 commented Mar 10, 2020

@benlangmuir Sounds like a good plan! I'll ping back when we've landed the SwiftPM change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.