fixed org.pkl.spring.boot.PklAutoConfiguration for Spring Boot 3.x#16
Merged
Conversation
bioball
reviewed
Mar 1, 2025
bioball
reviewed
Mar 1, 2025
bioball
reviewed
Mar 1, 2025
protobufel2
commented
Oct 8, 2025
Contributor
Author
protobufel2
left a comment
protobufel2
left a comment
There was a problem hiding this comment.
- updated Spring/Spring Boot to the latest version
- resolved minor requests (added new lines)
- applied spotlessApply
- commented regarding Spring Boot 2 compatibility - I think it's compatible.
Contributor
Author
|
@bioball Please approve so people can use it with Spring Boot 3 for sure :) |
Forbiddem
pushed a commit
to Forbiddem/pkl-spring
that referenced
this pull request
May 17, 2026
The CircleCI badge in README.adoc has been broken since CI moved to GitHub Actions (apple#19) and the CircleCI config was removed (apple#20). Other apple/pkl-* repos do not carry a CI status badge in their README, so drop it rather than substitute a new one. PklAutoConfiguration is already declared in META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports since apple#16, which makes the matching EnableAutoConfiguration entry in spring.factories redundant. The PropertySourceLoader entry is preserved because Spring Boot still loads PropertySourceLoader implementations exclusively from spring.factories.
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #14