Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PlatformDependent to `servicetalk-utils-internal` #879 #882

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@muthupalaniappan
Copy link
Contributor

muthupalaniappan commented Nov 28, 2019

Motivation:

PlatformDependent class lives in servicetalk-concurrent-internal module, but is not designed only for concurrent primitives. Different modules use it and therefore depend on servicetalk-concurrent-internal (and transitively on servicetalk-concurrent). This is not ideal, because requires unnecessary dependencies.

Modifications:

  • Moved files PlatformDependent.java, PlatformDependent0.java, ReflectionUtils.java from servicetalk-concurrent-internal module to servicetalk-utils-internal module.
  • Moved gradle/checkstyle/suppressions.xml from servicetalk-concurrent-internal module to servicetalk-utils-internal module.
  • Removed jctools dependency from servicetalk-concurrent-internal.
  • Added jctools and sl4j dependencies to servicetalk-utils-internal.
  • Added servicetalk-utils-internal project as implementation dependency to servicetalk-buffer-netty, servicetalk-concurrent-api, servicetalk-concurrent-api-internal, servicetalk-concurrent-internal, servicetalk-data-jakson, servicetalk-grps-api, servicetalk-transport-netty-internal.
  • Added servicetalk-utils-internal project as testImplementation dependency to servicetalk-grpc-netty and servicetalk-http-netty.
  • Removed servicetalk-concurrent-internal dependency from servicetalk-buffer-netty.
  • Modified a lot of class files import and static import statements to use io.servicetalk.util.internal... instead of io.servicetalk.concurrent.internal... for PlatformDependent, PlatformDependent0, ReflectionUtils classes and its inner static members.

Result:

PlatformDependent class moved into servicetalk-utils-internal module.

Fixes #879

Motivation:

PlatformDependent class lives in servicetalk-concurrent-internal module, but is not designed only for concurrent primitives. Different modules use it and therefore depend on servicetalk-concurrent-internal (and transitively on servicetalk-concurrent). This is not ideal, because requires unnecessary dependencies.

Modifications:

* Moved files PlatformDependent.java, PlatformDependent0.java, ReflectionUtils.java from servicetalk-concurrent-internal module(io.servicetalk.concurrent.internal package) to servicetalk-utils-internal module(io.servicetalk.utils.internal package).
* Moved gradle/checkstyle/suppressions.xml from servicetalk-concurrent-internal module to servicetalk-utils-internal module
* Removed jctools dependency from servicetalk-concurrent-internal
* Added jctools,sl4j dependency to servicetalk-utils-internal.
* Added servicetalk-utils-internal project as implementation dependency to servicetalk-buffer-netty, servicetalk-concurrent-api, servicetalk-concurrent-api-internal, servicetalk-concurrent-internal, servicetalk-data-jakson, servicetalk-grps-api, servicetalk-transport-netty-internal
* Added servicetalk-utils-internal project as testImplementation dependency to servicetalk-grpc-netty, servicetalk-http-netty
* Removed servicetalk-concurrent-internal dependency from servicetalk-buffer-netty
* Modified lot of class files import and static import statements to use io.servicetalk.util.internal... instead of io.servicetalk.concurrent.internal... for PlatformDependent, PlatformDependent0, ReflectionUtils classes and its inner static members.

Result:
Only internal changes and no API changes.

Fixes #879
@servicetalk-bot

This comment has been minimized.

Copy link
Contributor

servicetalk-bot commented Nov 28, 2019

Can one of the admins verify this patch?

3 similar comments
@servicetalk-bot

This comment has been minimized.

Copy link
Contributor

servicetalk-bot commented Nov 28, 2019

Can one of the admins verify this patch?

@servicetalk-bot

This comment has been minimized.

Copy link
Contributor

servicetalk-bot commented Nov 28, 2019

Can one of the admins verify this patch?

@servicetalk-bot

This comment has been minimized.

Copy link
Contributor

servicetalk-bot commented Nov 28, 2019

Can one of the admins verify this patch?

@idelpivnitskiy

This comment has been minimized.

Copy link
Member

idelpivnitskiy commented Nov 28, 2019

@servicetalk-bot test this please

@idelpivnitskiy idelpivnitskiy self-requested a review Dec 2, 2019
Copy link
Member

idelpivnitskiy left a comment

Great, we removed dependency on servicetalk-concurrent-internal for buffer-netty and data-jackson modules. Thanks for investigation @muthupalaniappan!

@idelpivnitskiy idelpivnitskiy merged commit 707d8be into apple:master Dec 2, 2019
3 checks passed
3 checks passed
pull request validation (jdk11) Build finished.
Details
pull request validation (jdk8) Build finished.
Details
pull request validation (quality) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.